Repository navigation
Conversation
sgbihu
force-pushed
the
fix_gpu_int64min
branch
from
November 5, 2026 23:44
8665927 to
eb5aef9
Compare
sgbihu
marked this pull request as ready for review
November 5, 2026 23:45
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The GPU Clamp lower-bound change has no active review issues blocking approval.
No open issues 🎉
What changed in this PR
This PR prevents out-of-range lower-bound conversion in GPU Clamp operations when i64 inputs are converted to i32 internally.
Changes:
- Restrict the GPU i32 Clamp lower bound to at least
INT32_MIN. - Add CPU and GPU regression cases for i32 and i64 inputs with lower bounds at
INT64_MIN, belowINT32_MIN, and atINT32_MIN.
| File | Description |
|---|---|
src/plugins/intel_gpu/tests/functional/shared_tests_instances/single_layer_tests/activation.cpp |
Adds six GPU Clamp lower-bound regression cases. |
src/plugins/intel_gpu/src/plugin/ops/unary.cpp |
Floors the i32 Clamp lower bound at INT32_MIN before conversion. |
src/plugins/intel_cpu/tests/functional/shared_tests_instances/single_layer_tests/activation.cpp |
Adds matching CPU Clamp lower-bound regression cases. |
Review effort: Balanced
sgbihu
force-pushed
the
fix_gpu_int64min
branch
from
November 6, 2026 05:37
eb5aef9 to
cc4aac5
Compare
sgbihu
force-pushed
the
fix_gpu_int64min
branch
from
November 6, 2026 11:01
cc4aac5 to
dba00f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
INT32_MINfor i32 GPU Clamp operations before converting bounds to float. This prevents out-of-rangeconvert_intvalues when the original lower bound is below the i32 range, such asINT64_MIN.ActivationLayerTestfor i32 and i64 inputs with lower boundsINT64_MIN,-2147483904, andINT32_MIN.Tickets:
AI Assistance: